Your assumption is incorrect. The commutator is not zero because the state function returned from $a_-a_+$ is not the same as that returned from $a_+a_-$. One may end up in the original energy eigenstate, but there are scalar constants which are part of the result, too. The scalar constants depend on the particular state you operate on and whether the operator is $a_-$ or $a_+$.
The primary basis of this is that $p$ and $x$ don't commute: $\left[ p,x\right]=-i\hbar.$
$$\left[ a_-,a_+\right]=\dfrac{1}{2m\omega\hbar}\left([p,p]+m^2\omega^2[x,x]+i2m\omega[p,x]\right)$$
(within a sign). That last term is not zero