This story actually starts with Einstein's paper on the photoelectric effect. Einstein proposed that for light waves, $E \propto f$, with a proportionality constant that eventually became known as $h$. Using the relation $E = pc$ from special relativity, you can derive that $pc = hf$, and with $\lambda f = c$ you get $\lambda = \frac{h}{p}$. Remember, though, so far this only applies to light. de Broglie's insight was to use the same relation to define the wavelength of a particle as a function of its momentum.
So where does your derivation go wrong? The key step is $v = \lambda f$, which applies to a wave, not a particle. As Qmechanic says, the wave velocity is not the same as the particle velocity. (The former is the phase velocity and the latter is the group velocity.)
Even though $\lambda = \frac{h}{p}$ was originally taken as an assumption, you can work backwards (or forwards, depending on your view) and derive it from a more general quantum theory. For example, suppose you start with the Schroedinger equation in free space,
$$i\hbar\frac{\partial \Psi(t,x)}{\partial t} = -\frac{\hbar^2}{2m}\frac{\partial^2 \Psi(t,x)}{\partial x^2}$$
Solutions to this equation take the form
$$\Psi(t,x) = \sum_n C_n\exp\biggl(-\frac{i}{\hbar}\bigl(E_nt \pm x\sqrt{2mE_n}\bigr)\biggr) = \sum_n C_n\exp\biggl[-i\biggl(\omega_nt \pm k_nx\biggr)\biggr]$$
This is a wave with multiple individual components, each having angular frequency $$\omega_n = E_n/\hbar$$ and wavenumber $$k_n = \frac{\sqrt{2mE_n}}{\hbar}$$ or equivalently, frequency $$f_n = E_n/h$$ and wavelength $$\lambda_n = \frac{h}{\sqrt{2mE_n}}$$ To come up with de Broglie's relation, you need to find an expression for the momentum carried by the wave. This is done using the momentum operator $\hat{p} = -i\hbar\frac{\partial}{\partial x}$ in $\hat{p}\Psi = p\Psi$. The thing is, it only works for a wavefunction with one component. So if (and only if) all the $C_n$ are zero except one, you can get
$$p_n = \mp\hbar k_n = \mp\sqrt{2m E_n}$$
and if you put that together with the definition of $\lambda_n$, you get $\lambda_n = \frac{h}{p_n}$.
It may seem like a problem that this procedure only works for single-component waves. It's okay, though, because the wave doesn't actually have a single well-defined wavelength anyway unless it consists of only one component. This is a key point: whenever you talk about the wavelength of a particle, or more precisely the wavelength of the matter wave associated with a particle, you're implicitly assuming that the matter wave has only a single frequency component. This is generally a useful approximation for real particles, but it's never exactly true.